Adds scan_accounts_without_data() to avoid loading account data #5849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
commented
Apr 16, 2025
| ScanAccountStorageData::NoData => { | ||
| storage.scan_accounts(|account| { | ||
| let account_without_data = StoredAccountInfoWithoutData::new_from(&account); | ||
| storage.scan_accounts_without_data(|account_without_data| { |
Author
There was a problem hiding this comment.
Here's the main change. We now do not load account data if scan_account_storage_data is NoData 🎉
| mut callback: impl for<'local> FnMut(StoredAccountInfoWithoutData<'local>), | ||
| ) -> TieredStorageResult<()> { | ||
| // Note, this should be reimplemented to not read account data | ||
| self.scan_accounts(|stored_account| { |
Author
There was a problem hiding this comment.
We can fix this Tiered Storage implementation later when we need to. I didn't think it was necessary for this PR though.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5849 +/- ##
=========================================
- Coverage 83.0% 83.0% -0.1%
=========================================
Files 828 828
Lines 375847 375890 +43
=========================================
+ Hits 312018 312023 +5
- Misses 63829 63867 +38 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AccountsDb::scan_account_storage()still loads account data in its back-end impl, even when we specifyScanAccountStorageData::NoData.Summary of Changes
Following on from #5840, we can now add a back-end method to not load the account data when scanning a storage. This PR adds
AccountsFile::scan_accounts_without_data().